nixpkgs/pkgs/tools/archivers/p7zip/default.nix

55 lines
1.9 KiB
Nix
Raw Normal View History

2020-11-25 16:43:49 +00:00
{ stdenv, fetchFromGitHub, fetchpatch, lib, enableUnfree ? false }:
stdenv.mkDerivation rec {
pname = "p7zip";
2020-11-25 16:43:49 +00:00
version = "17.03";
src = fetchFromGitHub {
owner = "szcnick";
repo = pname;
rev = "v${version}";
2020-11-25 16:43:49 +00:00
sha256 = "0zgpa90z5p30jbpqydiig1h8hn41c76n2x26rh8cc92xw72ni33d";
};
2020-12-21 18:01:38 +00:00
# Default makefile is full of impurities on Darwin. The patch doesn't hurt Linux so I'm leaving it unconditional
postPatch = ''
sed -i '/CC=\/usr/d' makefile.macosx_llvm_64bits
chmod +x install.sh
# I think this is a typo and should be CXX? Either way let's kill it
sed -i '/XX=\/usr/d' makefile.macosx_llvm_64bits
2021-01-15 09:19:50 +00:00
'' + lib.optionalString (stdenv.buildPlatform != stdenv.hostPlatform) ''
2018-10-12 12:36:48 +00:00
substituteInPlace makefile.machine \
--replace 'CC=gcc' 'CC=${stdenv.cc.targetPrefix}gcc' \
--replace 'CXX=g++' 'CXX=${stdenv.cc.targetPrefix}g++'
'' + lib.optionalString (!enableUnfree) ''
p7zip: remove non-free RAR support 7-Zip's RAR implementation is built on the non-free UnRAR source code; DOC/License.txt says: Licenses for files are: 1) CPP/7zip/Compress/Rar* files: GNU LGPL + unRAR restriction 2) All other files: GNU LGPL The GNU LGPL + unRAR restriction means that you must follow both GNU LGPL rules and unRAR restriction rules. ... unRAR restriction ----------------- The decompression engine for RAR archives was developed using source code of unRAR program. All copyrights to original unRAR code are owned by Alexander Roshal. The license for original unRAR code has the following restriction: The unRAR sources cannot be used to re-create the RAR compression algorithm, which is proprietary. Distribution of modified unRAR sources in separate form or as a part of other software is permitted, provided that it is clearly stated in the documentation and source comments that the code may not be used to develop a RAR (WinRAR) compatible archiver. The unrar licensing is [infamously restrictive and non-free][fedora]; it's inappropriate for us to keep the RAR support while labelling the package as free software (and indeed there's a commented-out line pointing out that the current `meta.license` is false). Unfortunately, the 7-Zip upstream seems uninterested in replacing the code with a freely-licensed alternative (see [7-Zip ticket #1229][7zip]). [fedora]: https://fedoraproject.org/wiki/Licensing:Unrar [7zip]: https://sourceforge.net/p/sevenzip/feature-requests/1229/ An alternative solution would be to mark the p7zip package as non-free instead; I decided not to because its other functionality (especially `.7z` support) is freely-licensed and useful, and there are free software alternatives for extracting RAR files (e.g. in nixpkgs there's `archiver`, which is written in a memory-safe language, and `unar`, which at least doesn't have two patches for CVEs that haven't been addressed upstream...). I checked that `7z(1)` fails gracefully on `.rar` files now: emily@renko ~/tmp> curl -L -O https://www.philippwinterberg.com/download/example.rar % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 5715k 100 5715k 0 0 6716k 0 --:--:-- --:--:-- --:--:-- 6716k emily@renko ~/tmp> 7z x example.rar 7-Zip [64] 16.02 : Copyright (c) 1999-2016 Igor Pavlov : 2016-05-21 p7zip Version 16.02 (locale=en_CA.UTF-8,Utf16=on,HugeFiles=on,64 bits,8 CPUs x64) Scanning the drive for archives: 1 file, 5853119 bytes (5716 KiB) Extracting archive: example.rar ERROR: example.rar Can not open the file as archive Can't open as archive: 1 Files: 0 Size: 0 Compressed: 0
2020-04-22 14:28:52 +00:00
# Remove non-free RAR source code
# (see DOC/License.txt, https://fedoraproject.org/wiki/Licensing:Unrar)
rm -r CPP/7zip/Compress/Rar*
find . -name makefile'*' -exec sed -i '/Rar/d' {} +
'';
2020-11-25 16:43:49 +00:00
makeFlags = [ "DEST_HOME=${placeholder "out"}" ];
2013-08-15 03:53:43 +00:00
preConfigure = ''
2020-11-25 16:43:49 +00:00
buildFlags=all3
2021-01-15 09:19:50 +00:00
'' + lib.optionalString stdenv.isDarwin ''
2020-11-25 16:43:49 +00:00
cp makefile.macosx_llvm_64bits makefile.machine
'';
2012-10-05 20:06:35 +00:00
enableParallelBuilding = true;
2016-12-17 12:04:59 +00:00
setupHook = ./setup-hook.sh;
2021-01-15 09:19:50 +00:00
NIX_CFLAGS_COMPILE = lib.optionalString stdenv.cc.isClang "-Wno-error=c++11-narrowing";
meta = {
homepage = "https://github.com/szcnick/p7zip";
description = "A new p7zip fork with additional codecs and improvements (forked from https://sourceforge.net/projects/p7zip/)";
2021-01-15 09:19:50 +00:00
platforms = lib.platforms.unix;
maintainers = [ lib.maintainers.raskin ];
p7zip: remove non-free RAR support 7-Zip's RAR implementation is built on the non-free UnRAR source code; DOC/License.txt says: Licenses for files are: 1) CPP/7zip/Compress/Rar* files: GNU LGPL + unRAR restriction 2) All other files: GNU LGPL The GNU LGPL + unRAR restriction means that you must follow both GNU LGPL rules and unRAR restriction rules. ... unRAR restriction ----------------- The decompression engine for RAR archives was developed using source code of unRAR program. All copyrights to original unRAR code are owned by Alexander Roshal. The license for original unRAR code has the following restriction: The unRAR sources cannot be used to re-create the RAR compression algorithm, which is proprietary. Distribution of modified unRAR sources in separate form or as a part of other software is permitted, provided that it is clearly stated in the documentation and source comments that the code may not be used to develop a RAR (WinRAR) compatible archiver. The unrar licensing is [infamously restrictive and non-free][fedora]; it's inappropriate for us to keep the RAR support while labelling the package as free software (and indeed there's a commented-out line pointing out that the current `meta.license` is false). Unfortunately, the 7-Zip upstream seems uninterested in replacing the code with a freely-licensed alternative (see [7-Zip ticket #1229][7zip]). [fedora]: https://fedoraproject.org/wiki/Licensing:Unrar [7zip]: https://sourceforge.net/p/sevenzip/feature-requests/1229/ An alternative solution would be to mark the p7zip package as non-free instead; I decided not to because its other functionality (especially `.7z` support) is freely-licensed and useful, and there are free software alternatives for extracting RAR files (e.g. in nixpkgs there's `archiver`, which is written in a memory-safe language, and `unar`, which at least doesn't have two patches for CVEs that haven't been addressed upstream...). I checked that `7z(1)` fails gracefully on `.rar` files now: emily@renko ~/tmp> curl -L -O https://www.philippwinterberg.com/download/example.rar % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 5715k 100 5715k 0 0 6716k 0 --:--:-- --:--:-- --:--:-- 6716k emily@renko ~/tmp> 7z x example.rar 7-Zip [64] 16.02 : Copyright (c) 1999-2016 Igor Pavlov : 2016-05-21 p7zip Version 16.02 (locale=en_CA.UTF-8,Utf16=on,HugeFiles=on,64 bits,8 CPUs x64) Scanning the drive for archives: 1 file, 5853119 bytes (5716 KiB) Extracting archive: example.rar ERROR: example.rar Can not open the file as archive Can't open as archive: 1 Files: 0 Size: 0 Compressed: 0
2020-04-22 14:28:52 +00:00
# RAR code is under non-free UnRAR license, but we remove it
license = if enableUnfree then lib.licenses.unfree else lib.licenses.lgpl2Plus;
};
}