Merge pull request #115260 from dotlambda/python-magic-fix

pythonPackages.python_magic: fix build and run tests
This commit is contained in:
Martin Weinelt 2021-03-07 01:09:31 +01:00 committed by GitHub
commit 1941313b6c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 42 additions and 13 deletions

View file

@ -1,25 +1,37 @@
{ buildPythonPackage, lib, fetchPypi, file, stdenv }:
{ lib
, stdenv
, python
, buildPythonPackage
, fetchFromGitHub
, substituteAll
, file
, glibcLocales
}:
buildPythonPackage rec {
pname = "python-magic";
version = "0.4.22";
src = fetchPypi {
inherit pname version;
sha256 = "ca884349f2c92ce830e3f498c5b7c7051fe2942c3ee4332f65213b8ebff15a62";
src = fetchFromGitHub {
owner = "ahupp";
repo = "python-magic";
rev = version;
sha256 = "0zbdjr5shijs0jayz7gycpx0kn6v2bh83dpanyajk2vmy47jvbd6";
};
postPatch = ''
substituteInPlace magic.py --replace "ctypes.util.find_library('magic')" "'${file}/lib/libmagic${stdenv.hostPlatform.extensions.sharedLibrary}'"
patches = [
(substituteAll {
src = ./libmagic-path.patch;
libmagic = "${file}/lib/libmagic${stdenv.hostPlatform.extensions.sharedLibrary}";
})
];
checkInputs = [ glibcLocales ];
checkPhase = ''
LC_ALL="en_US.UTF-8" ${python.interpreter} test/test.py
'';
doCheck = false;
# TODO: tests are failing
#checkPhase = ''
# ${python}/bin/${python.executable} ./test.py
#'';
meta = {
description = "A python interface to the libmagic file type identification library";
homepage = "https://github.com/ahupp/python-magic";

View file

@ -0,0 +1,17 @@
diff --git a/magic/loader.py b/magic/loader.py
index 6b2bfcb..69778af 100644
--- a/magic/loader.py
+++ b/magic/loader.py
@@ -5,11 +5,7 @@ import glob
def load_lib():
libmagic = None
# Let's try to find magic or magic1
- dll = ctypes.util.find_library('magic') \
- or ctypes.util.find_library('magic1') \
- or ctypes.util.find_library('cygmagic-1') \
- or ctypes.util.find_library('libmagic-1') \
- or ctypes.util.find_library('msys-magic-1') # for MSYS2
+ dll = '@libmagic@'
# necessary because find_library returns None if it doesn't find the library
if dll: