From 840fd0a4f8d1d7cd32328b9d853b34165884fdfc Mon Sep 17 00:00:00 2001 From: Robert Hensing Date: Wed, 14 Jul 2021 19:03:58 +0200 Subject: [PATCH] doc/coding-conventions: Increase passthru test timeout 3s -> 60s 3s is too small a margin for a loaded slow system to start a bloated program. This leads to problems when tests are written on decent dev hardware but later run on build farms of potentially slower hardware, particularly in the case of non x86. The chance of needing the timeout is actually very small, so those rare 57s are a reasonable price to pay for fewer timeouts on build farms, each of which should be investigated and usually fixed by increasing the timeout. --- doc/contributing/coding-conventions.chapter.md | 2 +- pkgs/tools/misc/phoronix-test-suite/tests.nix | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/contributing/coding-conventions.chapter.md b/doc/contributing/coding-conventions.chapter.md index e42ba512b98..240260105c3 100644 --- a/doc/contributing/coding-conventions.chapter.md +++ b/doc/contributing/coding-conventions.chapter.md @@ -568,7 +568,7 @@ let inherit (phoronix-test-suite) pname version; in -runCommand "${pname}-tests" { meta.timeout = 3; } +runCommand "${pname}-tests" { meta.timeout = 60; } '' # automatic initial setup to prevent interactive questions ${phoronix-test-suite}/bin/phoronix-test-suite enterprise-setup >/dev/null diff --git a/pkgs/tools/misc/phoronix-test-suite/tests.nix b/pkgs/tools/misc/phoronix-test-suite/tests.nix index 06bd9def9aa..85249c1242f 100644 --- a/pkgs/tools/misc/phoronix-test-suite/tests.nix +++ b/pkgs/tools/misc/phoronix-test-suite/tests.nix @@ -4,7 +4,7 @@ let inherit (phoronix-test-suite) pname version; in -runCommand "${pname}-tests" { meta.timeout = 3; } +runCommand "${pname}-tests" { meta.timeout = 60; } '' # automatic initial setup to prevent interactive questions ${phoronix-test-suite}/bin/phoronix-test-suite enterprise-setup >/dev/null