From 28f2dcc8b741049cf35d44775f1493d583cb719e Mon Sep 17 00:00:00 2001 From: Rickard Nilsson Date: Sun, 19 Jan 2020 22:41:44 +0100 Subject: [PATCH] pkgs/coreutils: Disable the df skip-rootfs test In the sandbox built for https://nixbuild.net, the coreutils build fails because a failure in the df skip-rootfs test. The test failure is triggered by the existance of a rootfs file system. However, I think that the test is faulty, and I have reported it upstream in https://lists.gnu.org/archive/html/bug-coreutils/2019-12/msg00000.html. Disabling the test makes the coreutils build work in the nixbuild.net sandbox, and I can't think of any negative impact disabling it can have. In normal nix setups and in the normal nix sandbox, this test is not exercised anyway, since there is no rootfs visible. --- pkgs/tools/misc/coreutils/default.nix | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/pkgs/tools/misc/coreutils/default.nix b/pkgs/tools/misc/coreutils/default.nix index 519a33c60d6..1294c6758f4 100644 --- a/pkgs/tools/misc/coreutils/default.nix +++ b/pkgs/tools/misc/coreutils/default.nix @@ -52,6 +52,10 @@ stdenv.mkDerivation (rec { sed '2i print "Skipping env -S test"; exit 77;' -i ./tests/misc/env-S.pl + # Fails on systems with a rootfs. Looks like a bug in the test, see + # https://lists.gnu.org/archive/html/bug-coreutils/2019-12/msg00000.html + sed '2i print "Skipping df skip-rootfs test"; exit 77' -i ./tests/df/skip-rootfs.sh + # these tests fail in the unprivileged nix sandbox (without nix-daemon) as we break posix assumptions for f in ./tests/chgrp/{basic.sh,recurse.sh,default-no-deref.sh,no-x.sh,posix-H.sh}; do sed '2i echo Skipping chgrp && exit 77' -i "$f"