From 3f7e683741583da08d2af51849eaf3132cd4d30d Mon Sep 17 00:00:00 2001 From: Luke Adams Date: Fri, 1 Jan 2021 00:27:58 +0000 Subject: [PATCH 1/2] pythonPackages.pkgconfig: change pkg-config to propagatedNativeBuildInput Dependent packages require pkg-config. Remove test-related overrides. Next version will include tests in the PyPi dist so there isn't much benefit to building from source just for that. --- .../python-modules/pkgconfig/default.nix | 15 +++++++-------- pkgs/top-level/python-packages.nix | 2 +- 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/pkgs/development/python-modules/pkgconfig/default.nix b/pkgs/development/python-modules/pkgconfig/default.nix index 05f13e8878a..1b03f720fbc 100644 --- a/pkgs/development/python-modules/pkgconfig/default.nix +++ b/pkgs/development/python-modules/pkgconfig/default.nix @@ -1,10 +1,10 @@ -{ lib, buildPythonPackage, fetchPypi, nose, pkgconfig }: +{ lib, buildPythonPackage, fetchPypi, pkg-config }: buildPythonPackage rec { pname = "pkgconfig"; version = "1.5.1"; - inherit (pkgconfig) + inherit (pkg-config) setupHooks wrapperName suffixSalt @@ -17,19 +17,18 @@ buildPythonPackage rec { sha256 = "97bfe3d981bab675d5ea3ef259045d7919c93897db7d3b59d4e8593cba8d354f"; }; - checkInputs = [ nose ]; - nativeBuildInputs = [ pkgconfig ]; + propagatedNativeBuildInputs = [ pkg-config ]; - checkPhase = '' - nosetests - ''; + doCheck = false; patches = [ ./executable.patch ]; postPatch = '' - substituteInPlace pkgconfig/pkgconfig.py --replace 'PKG_CONFIG_EXE = "pkg-config"' 'PKG_CONFIG_EXE = "${pkgconfig}/bin/${pkgconfig.targetPrefix}pkg-config"' + substituteInPlace pkgconfig/pkgconfig.py --replace 'PKG_CONFIG_EXE = "pkg-config"' 'PKG_CONFIG_EXE = "${pkg-config}/bin/${pkg-config.targetPrefix}pkg-config"' ''; + pythonImportsCheck = [ "pkgconfig" ]; + meta = with lib; { description = "Interface Python with pkg-config"; homepage = "https://github.com/matze/pkgconfig"; diff --git a/pkgs/top-level/python-packages.nix b/pkgs/top-level/python-packages.nix index 80f5f6cab1c..c31d2fa4d95 100644 --- a/pkgs/top-level/python-packages.nix +++ b/pkgs/top-level/python-packages.nix @@ -4667,7 +4667,7 @@ in { inherit (pkgs.libsForQt5) soqt; }; - pkgconfig = callPackage ../development/python-modules/pkgconfig { inherit (pkgs) pkgconfig; }; + pkgconfig = callPackage ../development/python-modules/pkgconfig { inherit (pkgs) pkg-config; }; pkginfo = callPackage ../development/python-modules/pkginfo { }; From 6c9f17eed16fa615d8ddedf8defcb6bd58c47502 Mon Sep 17 00:00:00 2001 From: Luke Adams Date: Fri, 1 Jan 2021 00:31:47 +0000 Subject: [PATCH 2/2] pythonPackages.pycapnp: Fix build for Py3k Also: - Disabled Py27: New versions don't support it - Fetch from github repo instead of PyPi --- .../python-modules/pycapnp/default.nix | 31 ++++++++++--------- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/pkgs/development/python-modules/pycapnp/default.nix b/pkgs/development/python-modules/pycapnp/default.nix index 1997021ce01..0d8dc6b53d8 100644 --- a/pkgs/development/python-modules/pycapnp/default.nix +++ b/pkgs/development/python-modules/pycapnp/default.nix @@ -1,34 +1,35 @@ { stdenv , buildPythonPackage -, fetchPypi , capnproto , cython +, fetchFromGitHub +, isPy27 , isPyPy -, isPy3k +, pkgconfig }: buildPythonPackage rec { pname = "pycapnp"; version = "1.0.0"; - disabled = isPyPy || isPy3k; + disabled = isPyPy || isPy27; - src = fetchPypi { - inherit pname version; - sha256 = "9f6fcca349ebf2ec04ca7eacb076aea3e4fcdc010ac33c98b54f0a19d4e5d3e0"; + src = fetchFromGitHub { + owner = "capnproto"; + repo = pname; + rev = "v${version}"; + sha256 = "1n6dq2fbagi3wvrpkyb7wx4y15nkm2grln4y75hrqgmnli8ggi9v"; }; - buildInputs = [ capnproto cython ]; + buildInputs = [ capnproto cython pkgconfig ]; - # import setuptools as soon as possible, to minimize monkeypatching mayhem. - postConfigure = '' - sed -i '3iimport setuptools' setup.py - ''; + # Tests disabled due to dependency on jinja and various other libraries. + doCheck = false; + + pythonImportsCheck = [ "capnp" ]; meta = with stdenv.lib; { - maintainers = with maintainers; [ cstrahan ]; + maintainers = with maintainers; [ cstrahan lukeadams ]; license = licenses.bsd2; - homepage = "http://jparyani.github.io/pycapnp/index.html"; - broken = true; # 2018-04-11 + homepage = "https://capnproto.github.io/pycapnp/"; }; - }