From fa7004fd2945a2ed113071c8c4222e78e968d80d Mon Sep 17 00:00:00 2001 From: Sebastian Graf Date: Mon, 19 Apr 2021 09:58:41 +0200 Subject: [PATCH] firefox: Remove `SNAP_NAME=firefox` in wrapper 082ed38 introduced it to fix the profile-per-install policy of FF 67. But since FF 69 (or 68?), there is `MOZ_LEGACY_PROFILES`, which we use since 87e2618. There is no reason for the `SNAP_NAME=firefox` workaround anymore. Additionally, the combination of `SNAP_NAME=firefox` with a large ~/.nix-profile/share in `XDG_DATA_DIRS` triggered https://bugzilla.mozilla.org/show_bug.cgi?id=1569625 for me, so this really fixes a bug in my configuration. The only downside of this approach is that we lose support for running FF 67 (and possibly 68). --- pkgs/applications/networking/browsers/firefox/wrapper.nix | 1 - 1 file changed, 1 deletion(-) diff --git a/pkgs/applications/networking/browsers/firefox/wrapper.nix b/pkgs/applications/networking/browsers/firefox/wrapper.nix index 390b26a1b9e..bc9cf8a326e 100644 --- a/pkgs/applications/networking/browsers/firefox/wrapper.nix +++ b/pkgs/applications/networking/browsers/firefox/wrapper.nix @@ -263,7 +263,6 @@ let --suffix PATH ':' "$out${browser.execdir or "/bin"}" \ --set MOZ_APP_LAUNCHER "${browserName}${nameSuffix}" \ --set MOZ_SYSTEM_DIR "$out/lib/mozilla" \ - --set SNAP_NAME "firefox" \ --set MOZ_LEGACY_PROFILES 1 \ --set MOZ_ALLOW_DOWNGRADE 1 \ ${lib.optionalString forceWayland ''