From 4e0bb261d0f9cde1075cffb98dc14f63ee44ea91 Mon Sep 17 00:00:00 2001 From: Lorenzo Manacorda Date: Mon, 30 Jan 2017 11:28:52 +0100 Subject: [PATCH] Make more visible which fetch approach is best Prepend "bad/better/best" to each paragraph, to make more visible which approach is best --- doc/coding-conventions.xml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/coding-conventions.xml b/doc/coding-conventions.xml index 4348dc8bf72..f89437af445 100644 --- a/doc/coding-conventions.xml +++ b/doc/coding-conventions.xml @@ -623,7 +623,7 @@ evaluate correctly. from bad to good: - Uses git:// which won't be proxied. + Bad: Uses git:// which won't be proxied. src = fetchgit { url = "git://github.com/NixOS/nix.git"; @@ -634,7 +634,7 @@ src = fetchgit { - This is ok, but an archive fetch will still be faster. + Better: This is ok, but an archive fetch will still be faster. src = fetchgit { url = "https://github.com/NixOS/nix.git"; @@ -645,7 +645,7 @@ src = fetchgit { - Fetches a snapshot archive and you get the rev you want. + Best: Fetches a snapshot archive and you get the rev you want. src = fetchFromGitHub { owner = "NixOS";