From cc06d7a26f247df071c551a980147baff8a75ff7 Mon Sep 17 00:00:00 2001
From: zowoq <59103226+zowoq@users.noreply.github.com>
Date: Tue, 4 Aug 2020 10:35:19 +1000
Subject: [PATCH] buildGoModule: change doCheck default to true
---
nixos/doc/manual/release-notes/rl-2009.xml | 5 +++++
pkgs/development/go-modules/generic/default.nix | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/nixos/doc/manual/release-notes/rl-2009.xml b/nixos/doc/manual/release-notes/rl-2009.xml
index d97e810b94c..5009ef4d873 100644
--- a/nixos/doc/manual/release-notes/rl-2009.xml
+++ b/nixos/doc/manual/release-notes/rl-2009.xml
@@ -664,6 +664,11 @@ services.postgresql.dataDir = "/var/db/postgresql";
The default output of buildGoPackage is now $out instead of $bin.
+
+
+ buildGoModule doCheck now defaults to true.
+
+
Packages built using buildRustPackage now use release
diff --git a/pkgs/development/go-modules/generic/default.nix b/pkgs/development/go-modules/generic/default.nix
index 68a4fe8dd6a..25b031a8229 100644
--- a/pkgs/development/go-modules/generic/default.nix
+++ b/pkgs/development/go-modules/generic/default.nix
@@ -210,7 +210,7 @@ let
runHook postBuild
'';
- doCheck = args.doCheck or false;
+ doCheck = args.doCheck or true;
checkPhase = args.checkPhase or ''
runHook preCheck