Commit graph

288322 commits

Author SHA1 Message Date
aszlig 74bff4e667
nixos/tests/unbound: Remove unused 'json' import
Signed-off-by: aszlig <aszlig@nix.build>
2021-05-09 02:28:30 +02:00
David Arnold 6ad2e41269
nixos/testing: lint jellyfin test 2021-05-09 02:28:28 +02:00
aszlig 6c0ec527b9
nixos/tests/shadow: Fix linting errors
Linter errors reported:

  6:32 f-string is missing placeholders
  7:26 f-string is missing placeholders
  8:32 f-string is missing placeholders
  30:32 f-string is missing placeholders
  31:26 f-string is missing placeholders
  32:32 f-string is missing placeholders
  48:32 f-string is missing placeholders
  49:26 f-string is missing placeholders
  50:32 f-string is missing placeholders
  76:32 f-string is missing placeholders
  77:26 f-string is missing placeholders
  78:32 f-string is missing placeholders

Signed-off-by: aszlig <aszlig@nix.build>
2021-05-09 02:28:26 +02:00
aszlig e157ad41cb
nixos/tests/printing: Remove unused 'sys' import
Signed-off-by: aszlig <aszlig@nix.build>
2021-05-09 02:28:23 +02:00
aszlig c066cc3c0b
nixos/tests/networking: Fix str literal comparison
Linter error:

  use ==/!= to compare constant literals (str, bytes, int, float, tuple)

Signed-off-by: aszlig <aszlig@nix.build>
2021-05-09 02:28:20 +02:00
aszlig 62a518b904
nixos/tests/yggdrasil: Fix linting error
Linter error was: f-string is missing placeholders

Signed-off-by: aszlig <aszlig@nix.build>
2021-05-09 02:28:18 +02:00
Maximilian Bosch b782440a62
nixosTests.custom-ca: lint 2021-05-09 02:28:16 +02:00
Maximilian Bosch b4b5dcb669
nixosTests.containers-imperative: lint 2021-05-09 02:28:14 +02:00
Maximilian Bosch fc76a44d0f
nixosTests.containers-custom-pkgs: lint
The new linter basically does

   def testScript
      # ...

before calling `pyflakes`. As this test-script is empty, it would lead
to a syntax-error unless `pass` is added.
2021-05-09 02:28:11 +02:00
Maximilian Bosch 774aba102a
nixosTests.chromium: lint
Note: I didn't execute it entirely because I'd have to build chromium
for this, but the diff appears fine.
2021-05-09 02:28:09 +02:00
Robert Hensing b9e7fb14e2
nixos/tests/nfs: lint 2021-05-09 02:28:07 +02:00
Robert Hensing 06b070ffe7
nixosTests.acme: lint 2021-05-09 02:28:04 +02:00
Robert Hensing 56d9637119
nixos/testing: Set up scope for testScript linter
Our test driver exposes a bunch of variables and functions, which
pyflakes doesn't recognise by default because it assumes that the test
script is executed standalone. In reality however the test driver script
is using exec() on the testScript.

Fortunately pyflakes has $PYFLAKES_BUILTINS, which are the attributes
that are globally available on all modules to be checked. Since we only
have one module, using this environment variable is fine as opposed to
my first approach to this, which tried to use the unstable internal API
of pyflakes.

The attributes are gathered by the main derivation of the test driver,
because we don't want to end up defining a new attribute in the test
driver module just to being confused why using it in a test will result
in an error.

Another way we could have gathered these attributes would be in
mkDriver, which is where the linting takes place. However, we do have a
different set of Python dependencies in scope and duplicating these will
again just cause confusion over having it at one location only.

Signed-off-by: aszlig <aszlig@nix.build>
Co-Authored-By: aszlig <aszlig@nix.build>
2021-05-09 02:26:51 +02:00
Robert Hensing 71087b2bc4
nixos/testing-python.nix: Expose driver
(cherry picked from commit a2c9220568648b4528154ebd8e657add243ed0b4)
2021-05-09 02:26:40 +02:00
aszlig c362a28fcf
nixos/testing: Switch from black to pyflakes
So far, we have used "black" for formatting the test code, which is
rather strict and opinionated and when used inline in Nix expressions it
creates all sorts of trouble.

One of the main annoyances is that when using strings coming from Nix
expressions (eg. store paths or option definitions from NixOS modules),
completely unrelated changes could cause tests to fail, since eg. black
wants lines to be broken.

Another downside of enforcing a certain kind of formatting is that it
makes the Nix expression code inconsistent because we're mixing two
spaces of indentation (common in nixpkgs) with four spaces of
indentation as defined in PEP-8. While this is perfectly fine for
standalone Python files, it really looks ugly and inconsistent IMO when
used within Nix strings.

What we actually want though is a linter that catches problems early on
before actually running the test, because this is *actually* helping in
development because running the actual VM test takes much longer.

This is the reason why I switched from black to pyflakes, because the
latter actually has useful checks, eg. usage of undefined variables,
invalid format arguments, duplicate arguments, shadowed loop vars and
more.

Signed-off-by: aszlig <aszlig@nix.build>
Closes: https://github.com/NixOS/nixpkgs/issues/72964
2021-05-09 02:26:37 +02:00
Jonathan Ringer d76e167bd5 kronosnet: 1.20 -> 1.21 2021-05-08 17:26:06 -07:00
Malte Brandy e60afba5d1
Merge branch 'master' into haskell-updates 2021-05-09 02:18:56 +02:00
R. RyanTM 7c4e0e3a90 activemq: 5.16.1 -> 5.16.2 2021-05-08 17:15:13 -07:00
R. RyanTM 9a153cb280 eventstat: 0.04.11 -> 0.04.12 2021-05-08 17:14:59 -07:00
maralorn 7333f7ae53
Merge pull request #122186 from sternenseemann/haskell-packages-platform-config 2021-05-09 02:14:04 +02:00
R. RyanTM ed09e90e95 matio: 1.5.20 -> 1.5.21 2021-05-08 17:12:09 -07:00
R. RyanTM 5ab09faafb gretl: 2021a -> 2021b 2021-05-08 17:11:36 -07:00
Robert T. McGibbon cba2ac2705 python3Packages.localzone: 0.9.7 -> 0.9.8 2021-05-08 17:10:23 -07:00
R. RyanTM cb2604ae1a klibc: 2.0.8 -> 2.0.9 2021-05-08 17:09:38 -07:00
Robert T. McGibbon da98a2dac8 python3Packages.crate: fix build 2021-05-08 17:09:01 -07:00
R. RyanTM db770a84f1 lilypond: 2.22.0 -> 2.22.1 2021-05-08 17:06:50 -07:00
Robert T. McGibbon dd7741f26e python3Packages.hyppo: fix build 2021-05-08 17:06:47 -07:00
Robert T. McGibbon 83fe0340fd python3Packages.ipympl: fix build 2021-05-08 17:05:07 -07:00
Robert T. McGibbon b4640b3cfc python3Packages.pyaftership: fix build 2021-05-08 17:03:04 -07:00
Robert T. McGibbon df68856b08 python3Packages.pyflume: fix build 2021-05-08 17:03:02 -07:00
R. RyanTM 2502b7cb91 libsolv: 0.7.17 -> 0.7.19 2021-05-08 17:01:00 -07:00
R. RyanTM 014d7ce377 liquibase: 4.3.2 -> 4.3.4 2021-05-08 16:59:51 -07:00
R. RyanTM ce420d9792 libwpe: 1.8.0 -> 1.10.0 2021-05-08 16:57:35 -07:00
sternenseemann f170298c9a top-level/release.nix: fix evaluation of jobset
We need to merge the set of complete jobs not of platforms to test on
since our aggregate jobs will always be “proper” jobs.
2021-05-09 01:49:17 +02:00
maralorn 4fc931999b
Merge pull request #122212 from sternenseemann/haskell-updates-recursive-update
top-level/release-haskell.nix: merge jobs using lib.recursiveUpdate
2021-05-09 01:44:18 +02:00
sternenseemann d52c2692e9
haskellPackages.language-docker: unbreak
sdist doesn't contain all the files necessary for the tests, so we need
to fetch the source from github instead.
2021-05-09 01:11:12 +02:00
R. RyanTM 3a9d159ed1 libsForQt5.fcitx5-qt: 5.0.4 -> 5.0.6 2021-05-09 01:11:05 +02:00
Dmitry Ivankov 3e3f1c02f2
haskellPackages.gi-gtk-declarative-app-simple: loosen haskell-gi version bound
https://hydra.nixos.org/build/142721471/nixlog/1

ZHF: #122042
2021-05-09 01:05:10 +02:00
Malte Brandy 66de11da71
maintainers/scripts/haskell/regenerate-hackage-packages.sh: Small improvents and encoding workaround 2021-05-09 01:01:33 +02:00
Robert T. McGibbon e7296ab998 python3Packages.pygmt: fix build 2021-05-08 15:52:02 -07:00
sternenseemann 6a0d9e5242 haskellPackages.paramtree: disable flaky test suite 2021-05-09 00:49:23 +02:00
Léo Gaspard 08b00c20e0
Merge pull request #118442 from Ekleog/nixos-tests
Add nixos tests with names starting by A or B to all relevant packages
2021-05-09 00:37:26 +02:00
R. RyanTM 7f1a670e79 findomain: 4.0.1 -> 4.1.0 2021-05-08 15:35:50 -07:00
R. RyanTM f0521b2416 codeql: 2.5.2 -> 2.5.3 2021-05-08 15:33:50 -07:00
R. RyanTM 49c8421f10 python38Packages.autopep8: 1.5.6 -> 1.5.7 2021-05-08 15:31:24 -07:00
Luke Granger-Brown 99f9c7c4d3 python3Packages.Markups: fix tests by providing PyYAML 2021-05-08 15:24:46 -07:00
Fabian Affolter 44442c4ad1
Merge pull request #121837 from fabaff/pyialarm
python3Packages.pyialarm: init at 1.5
2021-05-09 00:23:11 +02:00
R. RyanTM 4053d2e481 containerd: 1.4.4 -> 1.5.0 2021-05-08 15:21:02 -07:00
Robert T. McGibbon e7e6c1e37e python3Packages.dask-image: 0.5.0 -> 0.6.0 2021-05-08 15:20:20 -07:00
Robert T. McGibbon 1370970ca8 python3Packages.wordfeq: 2.3.2 -> 2.5 2021-05-08 15:20:00 -07:00