Commit graph

13 commits

Author SHA1 Message Date
Robin Gloster 356464388f
Merge pull request #69370 from chkno/no-extra-flags
makeWrapper: Remove unused extraFlagsArray feature
2019-10-09 01:32:28 +02:00
Tobias Mayer 2963c8811e ccls: 0.20190823 -> 0.20190823.3 2019-09-26 13:16:41 +02:00
Chuck a45b3ad89f
makeWrapper: Remove unused extraFlagsArray feature
There is a bug in this feature: It allows extra arguments to leak in
from the environment. For example:

  $ export extraFlagsArray=date
  $ man ls

Note that you get the man page for date rather than for ls. This happens
because 'man' happens to use a wrapper (to add groff to its PATH).

An attempt to fix this was made in 5ae18574fc in PR #19328 for
issue #2537, but 1. That change didn't actually fix the problem because
it addressed makeWrapper's environment during the build process, not the
constructed wrapper script's environment after installation, and 2. That
change was apparently accidentally lost when merged with 7ff6eec5fd.

Rather than trying to fix the bug again, we remove the extraFlagsArray
feature, since it has never been used in the public repo in the ten
years it has been available.

wrapAclocal continues to use its own, separate flavor of extraFlagsArray
in a more limited context. The analogous bug there was fixed in
4d7d10da6b in 2011.
2019-09-25 09:23:09 -07:00
Jörg Thalheim 2e0c19121a
Merge branch 'master' into ccls 2019-09-13 16:26:21 +01:00
MetaDark 5c22c8ba94 ccls: 0.20190314.1 -> 0.20190823 2019-08-31 10:03:32 -04:00
volth 46420bbaa3 treewide: name -> pname (easy cases) (#66585)
treewide replacement of

stdenv.mkDerivation rec {
  name = "*-${version}";
  version = "*";

to pname
2019-08-15 13:41:18 +01:00
Jörg Thalheim 144a031805
ccls: 0.20190301 -> 0.20190314.1 2019-05-30 11:42:39 +01:00
Jörg Thalheim fc3f98bb7d
Merge pull request #57217 from r-ryantm/auto-update/ccls
ccls: 0.20181225.8 -> 0.20190301
2019-03-10 09:43:39 +00:00
R. RyanTM cc27a10955 ccls: 0.20181225.8 -> 0.20190301
Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/ccls/versions
2019-03-09 21:47:37 -08:00
Väinö Järvelä 41a675258f Add Darwin support for ccls 2019-03-05 08:37:07 +02:00
Jörg Thalheim dadc7eb329
treewide: use runtimeShell instead of stdenv.shell whenever possible
Whenever we create scripts that are installed to $out, we must use runtimeShell
in order to get the shell that can be executed on the machine we create the
package for. This is relevant for cross-compiling. The only use case for
stdenv.shell are scripts that are executed as part of the build system.
Usages in checkPhase are borderline however to decrease the likelyhood
of people copying the wrong examples, I decided to use runtimeShell as well.
2019-02-26 14:10:49 +00:00
R. RyanTM 9f93aa092c ccls: 0.20181225.7 -> 0.20181225.8
Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/ccls/versions
2019-02-06 08:10:11 -08:00
Jörg Thalheim ca61531750
ccls: init at 0.20181225
- tested with [emacs](https://dl.thalheim.io/kdh-PwxzlwGKTEl1_NpTzg/2019-01-13-190156_1920x1080_scrot.png)
and vim.
- wrapped to pick up our cc wrapper environment -> works perfectly in nix-shell
2019-01-15 17:12:56 +00:00