Commit graph

27 commits

Author SHA1 Message Date
aszlig fa6fd34fcc
github/pr-template: Add note about NixOS tests
On several occasions I've seen people bumping packages which have NixOS
tests but without actually running them.

While this probably won't prevent such occasions entirely, at least it
serves as an additional checklist item so contributors don't forget
about these tests.

Signed-off-by: aszlig <aszlig@redmoonstudios.org>
2017-06-23 05:33:06 +02:00
Alexey Shmalko f5bed28db8
github issue template: add sandboxing info 2017-05-01 15:38:11 +03:00
Hannu Hartikainen 9ed8627a76 CONTRIBUTING.md: improve commit message guidelines
Add a brief request for expressing the motivation for a change. Change the example commit messages to match.

Resolves #19126.
2017-02-06 22:26:32 +02:00
Vladimír Čunát b59167ce0e
CONTRIBUTING.md: switch to a link that actually works
Fixes #20594.
2016-11-24 10:01:16 +01:00
Ignat Loskutov d91eba4ec3 Update PULL_REQUEST_TEMPLATE.md
Follow the rebranding of OS X into macOS
2016-11-04 18:49:40 +03:00
zimbatm 0e3e7a6bcd Merge pull request #18972 from ericsagnes/doc/reviewing-contributions
[WIP] nixos-doc: add reviewing contributions chapter
2016-10-01 15:09:12 +01:00
Eric Sagnes 7ad26bdc6e improvements from feedback 2016-09-28 11:05:22 +09:00
Eric Sagnes 8d656d2ca0 nixos-doc: add reviewing-contributions 2016-09-26 15:44:06 +09:00
Wink Saville 0f386457e3 Update broken link in CONTRIBUTING.md
The current link returns a 404 error
2016-09-23 16:33:47 -07:00
Rushmore Mushambi 0192777972 PULL_REQUEST_TEMPLATE: rename chroot to sandbox
See b39622a487
2016-09-02 21:41:43 +02:00
Vladimír Čunát 156105c489 PR template: go back to old option name for now
The old one works on all nix(os) versions, whereas the new one doesn't
work e.g. on default 16.03 setting. Discussed on #15112.
2016-06-29 21:44:05 +02:00
Daniel Peebles 0bd54a6d5d Update PR template with motivation for changes
I'm seeing a lot of PRs that only include the checklist, when the main thing I care about when I'm reviewing a PR is what the author was thinking when they decided to make the change.
2016-05-24 07:59:46 -04:00
Vladimír Čunát 4c10d404e7 github PR template: reformulate the sandboxing help
It's been reported that when running through nix daemon,
sandboxing can't be turned on by passing `--option` (silently ignored),
so let's not suggest that way.
https://github.com/NixOS/nixpkgs/issues/14866#issuecomment-214619909
2016-04-26 09:18:15 +02:00
Vladimír Čunát 7cf8daa2bb nixos: rename chroot* to sandbox*
On Nix side this was done months ago:
https://github.com/NixOS/nix/pull/682
2016-04-25 11:04:08 +02:00
zimbatm 3b33c3628a fixup! Simplify contributing 2016-04-09 20:51:26 +01:00
zimbatm 8706726d59 Simplify contributing
* Highlight the top mistakes directly in CONTRIBUTING.md
* Remove unecessary cruft from the PR template
2016-04-09 17:59:35 +01:00
Jakob Gillich 0d091ffd4a simplify ISSUE_TEMPLATE 2016-03-31 16:14:54 +02:00
Nathan Zadoks d0b8080062 .github/PULL_REQUEST_TEMPLATE.md: use individual checkboxes for tested OSes 2016-03-16 09:46:05 +01:00
Domen Kožar 2af46e4393 PULL_REQUEST_TEMPLATE: fix issues raised in 3c84ae406 2016-02-28 09:26:28 +00:00
Domen Kožar 3c84ae406d PULL_REQUEST_TEMPLATE.md: clarify a few things 2016-02-28 08:50:33 +00:00
Eelco Dolstra 830c2d6389 ISSUE_TEMPLATE.md: Tweak 2016-02-23 17:06:55 +01:00
Domen Kožar 71c231e2a6 Merge pull request #13388 from spacefrogg/contributing-fix
CONTRIBUTING.md: Fix link to COPYING
2016-02-23 14:07:19 +00:00
Michael Raitza d53fa9884b CONTRIBUTING.md: Fix link to COPYING 2016-02-23 13:50:01 +00:00
zimbatm 4ba3c96431 .github/ISSUE_TEMPLATE.md - get more information
The goal is to get all the necessary information from the reporter upfront.
Too many times the issues submits and we need to do a round of asking before
we can get close to a solution.
2016-02-23 12:09:41 +00:00
Arseniy Seroka e4d0811c8b Merge pull request #13100 from jagajaga/improvements
PULL_REQUEST_TEMPLATE: init
2016-02-22 13:47:34 +03:00
Arseniy Seroka ac9ab2c3f5 PULL_REQUEST_TEMPLATE: init 2016-02-22 13:45:56 +03:00
Eelco Dolstra 88f5d1c8ba Move CONTRIBUTING.md to .github
See https://github.com/blog/2111-issue-and-pull-request-templates.
2016-02-19 10:59:38 +01:00