Commit graph

893 commits

Author SHA1 Message Date
github-actions[bot] 481a9bc47c
Merge master into staging-next 2021-04-23 00:15:39 +00:00
Martin Weinelt e75f053238
Merge pull request #119434 from ooesili/firefox-ld-path-prefix
Add Firefox libs to beginning of LD_LIBRARY_PATH
2021-04-22 20:25:45 +02:00
Martin Weinelt 6b34489f81
Merge branch 'master' into staging-next 2021-04-20 02:06:07 +02:00
Bernardo Meurer 44fa00a5b8
Merge pull request #119862 from mweinelt/firefox
firefox: 87.0 -> 88.0; firefox-esr: 78.9.0esr -> 78.10.0esr
2021-04-19 19:33:42 +00:00
github-actions[bot] 6ef7c23763
Merge master into staging-next 2021-04-19 18:11:51 +00:00
Sebastian Graf fa7004fd29 firefox: Remove SNAP_NAME=firefox in wrapper
082ed38 introduced it to fix the profile-per-install policy of FF 67. But since
FF 69 (or 68?), there is `MOZ_LEGACY_PROFILES`, which we use since 87e2618.
There is no reason for the `SNAP_NAME=firefox` workaround anymore.

Additionally, the combination of `SNAP_NAME=firefox` with
a large ~/.nix-profile/share in `XDG_DATA_DIRS` triggered
https://bugzilla.mozilla.org/show_bug.cgi?id=1569625 for me, so this really
fixes a bug in my configuration.

The only downside of this approach is that we lose support for running FF 67
(and possibly 68).
2021-04-19 14:33:19 +02:00
Martin Weinelt af13285fff
firefox-esr: 78.9.0esr -> 78.10.0esr
https://www.mozilla.org/en-US/firefox/78.10.0/releasenotes/
2021-04-19 13:58:29 +02:00
Martin Weinelt 8fe28fb308
firefox: 87.0 -> 88.0
https://www.mozilla.org/en-US/firefox/88.0/releasenotes/
2021-04-19 13:58:00 +02:00
Wesley Merkel 2fc271ffdd Add Firefox libs to beginning of LD_LIBRARY_PATH
When firefox is executed by programs that also make changes to
`LD_LIBRARY_PATH`, the paths can conflict causing firefox to look for
shared libraries in the wrong location. This is because the wrapper
script around firefox *appends* library paths to `LD_LIBRARY_PATH`
instead of prepending them, causing library paths that are already in
the environment to take precedence over the library paths that firefox
depends on.

As an example, Discord and firefox both depend on different versions of
libnss. When Discord launches firefox, which happens when clicking on
hyperlinks, the path in `LD_LIBRARY_PATH` to libnss set by Discord takes
precedence over then one set by the firefox wrapper script causing
firefox to load a different version of libnss than the one it was built
against. This causes a fatal error in firefox which prevents it from
starting.

This commit fixes this issue by switching the firefox wrapper script to
*prepend* its library paths to `LD_LIBRARY_PATH`.

Fixes #118432
2021-04-14 10:52:28 -05:00
Luke Granger-Brown 08b22e605b Merge remote-tracking branch 'upstream/staging-next' into down-integrate-staging 2021-04-12 18:49:01 +00:00
Luis Hebendanz 94d7d46e20 firefox/wrapper.nix: Fixed firefox is always 'managed by your organization' 2021-04-10 01:46:18 +02:00
Gabriel Ebner c08d9a7e02 firefox: add missing libdrm and libXdamage dependencies 2021-04-09 09:26:12 +02:00
Sandro Jäckel dcb501f993
kerberos: deprecate alias 2021-04-04 03:18:56 +02:00
Martin Weinelt 4a8aaa58ad
firefox, firefox-esr: add myself to maintainers 2021-03-22 16:09:57 +01:00
Martin Weinelt 9a0519f080
firefox-esr: 78.8.0esr -> 78.9.0esr 2021-03-22 15:05:56 +01:00
Martin Weinelt e9dbf1a586
firefox: 86.0.1 -> 87.0 2021-03-22 15:05:37 +01:00
Martin Weinelt 5ad7e11e5d
firefox: 86.0 -> 86.0.1 2021-03-12 04:17:38 +01:00
Frederik Rietdijk 277d488026 Merge staging into staging-next 2021-03-08 19:20:18 +01:00
Lluís Batlle i Rossell d2af381b40 firefox: build in 32-bit systems
Disabling "-g" and LTO so there aren't memory problems.
2021-03-07 19:37:15 +01:00
Ben Siraphob 4f0cdb68d7 treewide: unzip buldInputs to nativeBuildInputs (2) 2021-03-06 15:18:05 +07:00
Martin Weinelt 7b9c874d67
firefox-esr: 78.7.1esr -> 78.8.0esr
/cc original PR #114152.  ESR doesn't need to go through staging.
I briefly ran it on X11 x86_64 NixOS and checked build on aarch64.
(for other's testing see the PR linked above)
2021-02-24 18:41:30 +01:00
Martin Weinelt 059e818b2f
firefox: 85.0.2 -> 86.0 2021-02-24 15:06:49 +01:00
Martin Weinelt 841fcbdb17
firefox-esr: 78.7.1esr -> 78.8.0esr 2021-02-24 15:06:49 +01:00
taku0 0253d3097d
Merge pull request #112491 from xaverdh/firefox-plugins-cleanup
firefox/wrapper: clean up plugin related code
2021-02-20 15:17:16 +09:00
Martin Weinelt c76ad6f1af
firefox: 85.0.1 -> 85.0.2 2021-02-11 03:15:06 +01:00
Dominik Xaver Hörl ac2e3ef270 firefox/wrapper: clean up plugin related code 2021-02-09 19:52:54 +01:00
Bernardo Meurer 76dc1086dc
firefox: remove flash support 2021-02-08 09:38:40 -08:00
Martin Weinelt f30c67cc99
firefox: patch libpci.so{,.3} path in glxtest
Crash Annotation GraphicsCriticalError: |[0][GFX1-]: glxtest: libpci missing (t=0.460635) [GFX1-]: glxtest: libpci missing
2021-02-07 17:01:48 +01:00
taku0 f2c8ad694b
Merge pull request #112270 from lovesegfault/firefox-update
firefox-bin: 85.0 -> 85.0.1
2021-02-07 18:13:44 +09:00
Bernardo Meurer 326d14c08b
firefox: add lovesegfault as a maintainer 2021-02-07 00:07:00 -08:00
Martin Weinelt 093e65509b firefox-esr: 78.7.0esr -> 78.7.1esr 2021-02-06 20:01:15 +01:00
Martin Weinelt 5022f548fe firefox: 85.0 -> 85.0.1 2021-02-06 20:01:15 +01:00
Tim Steinbach 77665740b5 firefox: Add test references 2021-02-03 10:26:42 -05:00
Ben Siraphob a6ac3eedbd treewide: xdg_utils -> xdg-utils 2021-02-01 15:05:09 +07:00
Martin Weinelt ee3fca55d5
firefox-esr: 78.6.1esr -> 78.7.0esr 2021-01-28 04:09:15 +01:00
Martin Weinelt 63e8aa549c
firefox: 84.0.2 -> 85.0 2021-01-28 04:09:15 +01:00
github-actions[bot] 9541eb734d
Merge master into staging-next 2021-01-17 12:38:49 +00:00
Bernardo Meurer 9fcf3e5c25
Merge pull request #109598 from S-NA/wip/firefox-aarch64-lto
firefox: limit disable-elf-hack to arm, x86{,_64}
2021-01-17 08:03:35 +00:00
Ben Siraphob 5d566c43b4 pkgs/applications: pkgconfig -> pkg-config 2021-01-16 23:49:59 -08:00
Jan Tojnar e6f926d910
Merge branch 'master' into staging-next 2021-01-17 05:52:23 +01:00
S. Nordin Abouzahra 00b75b7024 firefox: limit disable-elf-hack to arm, x86{,_64}
This is a follow up to #106617 which brought LTO support but broke the
AArch64 Firefox builds.
2021-01-16 22:26:40 -05:00
Bernardo Meurer aa4a14b7ad
Merge pull request #106617 from S-NA/wip/firefox-improvements
firefox: fix running wayland firefox built with LTO and some miscellaneous improvements
2021-01-16 23:17:57 +00:00
Jan Tojnar c0d2951fa6
Merge branch 'master' into staging-next 2021-01-15 17:46:46 +01:00
Ben Siraphob 108bdac3d9 pkgs/applications: stdenv.lib -> lib 2021-01-15 14:24:03 +07:00
S. Nordin Abouzahra dbe008a52a firefox: remove python2 dependency
Python 2 is no longer required to build Firefox.
2021-01-13 08:06:48 -05:00
S. Nordin Abouzahra 7415d0589d firefox: overhaul LTO
Enable LTO support on Linux by default again.

Add patch to fix dependentlibs.list generation under LTO. This is
necessary for fixing firefox-wayland crashing when built with LTO.

Add makeFlags which set ar, ranlib, and nm to be llvm-ar, llvm-ranlib
and llvm-nm when building with llvm-based LTO. (bmo#1480005)
2021-01-13 08:06:48 -05:00
S. Nordin Abouzahra 40b4eb1c52 firefox: simplify NIX_LDFLAGS usage
This was required to solve the XPCOMGlueLoad error when building with
LTO. However, it turns out libxul.so is supposed to have some libraries
that are reported as not found by ldd. Setting the RPATH worked around
the error as it forced dependency resolution but failed to fix the real
issue of broken generation of dependentlibs.list.

The libraries that are reported as not found by ldd are supposed to be
dlopened through the logic found in nsXPCOMGlue.cpp. However since the
generation of dependentlibs.list is broken under LTO this did not
happen. Instead of pulling libwayland-client.so from the GTK libraries
it found the stub library first (libmozwayland.so). The stub library
causes (as it should) wl_display_connect to always return NULL which is
the cause of the segmentation fault and LTO breaking wayland support.

Remove the hardcoded path used for the XPCOMGlueLoad error workaround
in NIX_LDFLAGS. libunwind is still unfortunately needed. Once the issue
of the generation of dependentlibs.list being borked is fixed it should
remedy the wayland crash issue on LTO.
2021-01-13 08:06:47 -05:00
S. Nordin Abouzahra a277fca1c4 firefox: remove patchelf usage
Firefox has a number of optional dependencies that get dlopened.
Instead of using patchelf to set the RPATH use LD_LIBRARY_PATH.
The motivation for this is we already set LD_LIBRARY_PATH in the
wrapper on Linux.
2021-01-13 08:06:46 -05:00
S. Nordin Abouzahra 80e863c52c firefox: clean up optionals
Change `lib.optionals a [ b ]` to `lib.optional a b`.
2021-01-13 08:06:45 -05:00
S. Nordin Abouzahra 96c34702e9 firefox: restrict system NSPR workaround
It only affected FF80 so place an upper bound restriction. See
bmo#1661096 for details.

This fixes substituteStream() warnings about missing patterns which
appeared in the logs.
2021-01-13 08:06:45 -05:00