nixpkgs/pkgs/development/libraries/exiv2/default.nix
Anders Kaseorg 3cd8ce3bce treewide: Fix unsafe concatenation of $LD_LIBRARY_PATH
Naive concatenation of $LD_LIBRARY_PATH can result in an empty
colon-delimited segment; this tells glibc to load libraries from the
current directory, which is definitely wrong, and may be a security
vulnerability if the current directory is untrusted.  (See #67234, for
example.)  Fix this throughout the tree.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2020-01-15 09:47:03 +01:00

103 lines
2 KiB
Nix

{ stdenv
, fetchFromGitHub
, zlib
, expat
, cmake
, which
, libxml2
, python3
, gettext
, doxygen
, graphviz
, libxslt
}:
stdenv.mkDerivation rec {
pname = "exiv2";
version = "0.27.2";
src = fetchFromGitHub {
owner = "exiv2";
repo = "exiv2";
rev = "v${version}";
sha256 = "0n8il52yzbmvbkryrl8waz7hd9a2fdkw8zsrmhyh63jlvmmc31gf";
};
cmakeFlags = [
"-DEXIV2_BUILD_PO=ON"
"-DEXIV2_BUILD_DOC=ON"
];
outputs = [ "out" "dev" "doc" "man" ];
nativeBuildInputs = [
cmake
doxygen
gettext
graphviz
libxslt
];
propagatedBuildInputs = [
expat
zlib
];
checkInputs = [
libxml2.bin
python3
which
];
buildFlags = [
"doc"
];
doCheck = true;
# Test setup found by inspecting ${src}/.travis/run.sh; problems without cmake.
checkTarget = "tests";
preCheck = ''
patchShebangs ../test/
mkdir ../test/tmp
export LD_LIBRARY_PATH="$(realpath ../build/lib)"
# Fix tests on Aarch64
${stdenv.lib.optionalString stdenv.isAarch64 ''
rm -f ../tests/bugfixes/github/test_CVE_2018_12265.py
''}
${stdenv.lib.optionalString stdenv.isDarwin ''
export DYLD_LIBRARY_PATH=$DYLD_LIBRARY_PATH''${DYLD_LIBRARY_PATH:+:}`pwd`/lib
# Removing tests depending on charset conversion
substituteInPlace ../test/Makefile --replace "conversions.sh" ""
rm -f ../tests/bugfixes/redmine/test_issue_460.py
rm -f ../tests/bugfixes/redmine/test_issue_662.py
''}
'';
postCheck = ''
(cd ../tests/ && python3 runner.py)
'';
# With cmake we have to enable samples or there won't be
# a tests target. This removes them.
postInstall = ''
( cd "$out/bin"
mv exiv2 .exiv2
rm *
mv .exiv2 exiv2
)
'';
enableParallelBuilding = true;
meta = with stdenv.lib; {
homepage = https://www.exiv2.org/;
description = "A library and command-line utility to manage image metadata";
platforms = platforms.all;
license = licenses.gpl2Plus;
};
}