nixpkgs/pkgs
aszlig 593062ddc2
fetchFromGitLab: Fix grouping issue for group arg
Issue introduced by c3612b97e6.

Example output before that commit (witch a random package using
fetchFromGitLab):

$ nix-instantiate --eval -A hiawatha.src.urls
[ "https://gitlab.com/api/v4/projects/hsleisink%2Fhiawatha/repository/archive.tar.gz?sha=v10.8.1" ]

After the commit:

$ nix-instantiate --eval -A hiawatha.src.urls
[ "https://gitlab.com/api/v4/projects/%2Fhsleisink%2Fhiawatha/repository/archive.tar.gz?sha=v10.8.1" ]

And with this very commit, which fixes the issue:

$ nix-instantiate --eval -A hiawatha.src.urls
[ "https://gitlab.com/api/v4/projects/hsleisink%2Fhiawatha/repository/archive.tar.gz?sha=v10.8.1" ]

The problem was that it has used optionalString in conjunction with "+",
so the optionalString only applied to the left-hand side of the +
operator.

Thanks to @ryantm for reporting the issue at:

c3612b97e6 (r220576764)

Signed-off-by: aszlig <aszlig@nix.build>
Reported-by: Ryan Mulligan <ryan@ryantm.com>
2018-09-26 16:17:18 +02:00
..
applications gitAndTools.pass-git-helper: init at 0.4 (#47056) 2018-09-26 13:46:05 +01:00
build-support Revert "virtualization/qemu-vm: fix and improve virtio/scsi switching" 2018-09-25 11:10:10 +02:00
common-updater
data all-cabal-hashes: update snapshot to Hackage at 2018-09-18T11:13:20Z 2018-09-24 21:19:34 +02:00
desktops Merge pull request #45941 from NixOS/staging-next 2018-09-23 09:31:28 +02:00
development nodejs-10_x: 10.9.0 -> 10.11.0 2018-09-26 11:49:18 +02:00
games Merge pull request #46586 from elitak/factorio 2018-09-22 19:57:12 +00:00
misc arc-theme: 2017-05-12 -> 20180715 (#43490) 2018-09-26 15:56:47 +02:00
os-specific nfs-utils: 2.3.2 -> 2.3.3 (#46989) 2018-09-26 15:36:31 +02:00
servers Merge pull request #47319 from r-ryantm/auto-update/cadvisor 2018-09-25 23:02:44 +01:00
shells zsh: 5.6.1 -> 5.6.2 2018-09-15 00:05:48 -05:00
stdenv stdenv: partial revert of f2bb59 2018-09-26 02:09:22 -05:00
test tests: add variants for llvm7 2018-09-23 13:30:17 -05:00
tools google-compute-engine: 20180510 -> 20180905 2018-09-26 11:48:16 +02:00
top-level fetchFromGitLab: Fix grouping issue for group arg 2018-09-26 16:17:18 +02:00