nixpkgs/pkgs
Alyssa Ross 69dcb1a2c0 bundlerApp: take buildInputs (#45435)
It would be reasonable to have a Ruby program that depends on some other
program being in the PATH. In this case, the obvious thing to do would
be something like this:

    bundlerApp {
      # ...
      buildInputs = [ makeWrapper ];
      postBuild = ''
        wrapProgram "$out/bin/foo" \
          --prefix PATH : ${lib.makeBinPath [ dep ]}
      '';
    }

However, this doesn't work, because even though it just forwards most of
its arguments to `runCommand`, `bundlerApp` won't take a `buildInputs`
parameter. It doesn't even specify its own `buildInputs`, which means
that the `scripts` parameter to `bundlerApp` (which depends on
`makeWrapper`) is completely broken, and, as far as I can tell, has been
since its inception. I've added a `makeWrapper` build input if the
scripts parameter is present to fix this.

I've added a `buildInputs` option to `bundlerApp`. It's also passed
through to bundled-common because `postBuild` scripts are run there as
well. This actually means that in this example we'd end up going through
two layers of wrappers (one from `bundlerApp` and one from
bundled-common), but that has always been the case and isn't likely to
break anything. That oddity does suggest that it might be prudent to
not forward `postBuild` to bundled-common (or to at least use a
different option) though...

FWIW, as far as I can tell no package in nixpkgs uses either the
`scripts` or `postBuild` options to `bundlerApp`.
2018-10-29 22:39:51 +01:00
..
applications gitlab: 11.4.0 -> 11.4.3 2018-10-29 20:42:02 +01:00
build-support defaultCrateOverrides: add serde_derive 2018-10-28 21:59:19 +00:00
common-updater
data Merge pull request #49085 from hamishmack/google-fonts-macos 2018-10-29 20:46:44 +00:00
desktops adwaita-icon-theme: 3.28.0 -> 3.30.0 2018-10-28 21:58:58 +01:00
development bundlerApp: take buildInputs (#45435) 2018-10-29 22:39:51 +01:00
games Merge pull request #49095 from Synthetica9/steam-update 2018-10-28 21:43:50 +01:00
misc splix: add missing printer models 2018-10-29 10:45:09 +01:00
os-specific zfs{Stable,Unstable}: mark as incompatible with 4.19 2018-10-29 07:43:28 +00:00
servers home-assistant: 0.81.0 -> 0.81.1 2018-10-29 13:39:37 +01:00
shells Merge pull request #49086 from dtzWill/update/zsh-completions 2018-10-25 14:59:25 +01:00
stdenv
test Remove openftd 2018-10-21 21:52:20 +02:00
tools ibus: fix cross compilation 2018-10-29 13:45:40 -05:00
top-level Merge pull request #49070 from r-ryantm/auto-update/python3.6-dlib 2018-10-29 19:27:07 +01:00