Commit graph

288093 commits

Author SHA1 Message Date
aszlig c066cc3c0b
nixos/tests/networking: Fix str literal comparison
Linter error:

  use ==/!= to compare constant literals (str, bytes, int, float, tuple)

Signed-off-by: aszlig <aszlig@nix.build>
2021-05-09 02:28:20 +02:00
aszlig 62a518b904
nixos/tests/yggdrasil: Fix linting error
Linter error was: f-string is missing placeholders

Signed-off-by: aszlig <aszlig@nix.build>
2021-05-09 02:28:18 +02:00
Maximilian Bosch b782440a62
nixosTests.custom-ca: lint 2021-05-09 02:28:16 +02:00
Maximilian Bosch b4b5dcb669
nixosTests.containers-imperative: lint 2021-05-09 02:28:14 +02:00
Maximilian Bosch fc76a44d0f
nixosTests.containers-custom-pkgs: lint
The new linter basically does

   def testScript
      # ...

before calling `pyflakes`. As this test-script is empty, it would lead
to a syntax-error unless `pass` is added.
2021-05-09 02:28:11 +02:00
Maximilian Bosch 774aba102a
nixosTests.chromium: lint
Note: I didn't execute it entirely because I'd have to build chromium
for this, but the diff appears fine.
2021-05-09 02:28:09 +02:00
Robert Hensing b9e7fb14e2
nixos/tests/nfs: lint 2021-05-09 02:28:07 +02:00
Robert Hensing 06b070ffe7
nixosTests.acme: lint 2021-05-09 02:28:04 +02:00
Robert Hensing 56d9637119
nixos/testing: Set up scope for testScript linter
Our test driver exposes a bunch of variables and functions, which
pyflakes doesn't recognise by default because it assumes that the test
script is executed standalone. In reality however the test driver script
is using exec() on the testScript.

Fortunately pyflakes has $PYFLAKES_BUILTINS, which are the attributes
that are globally available on all modules to be checked. Since we only
have one module, using this environment variable is fine as opposed to
my first approach to this, which tried to use the unstable internal API
of pyflakes.

The attributes are gathered by the main derivation of the test driver,
because we don't want to end up defining a new attribute in the test
driver module just to being confused why using it in a test will result
in an error.

Another way we could have gathered these attributes would be in
mkDriver, which is where the linting takes place. However, we do have a
different set of Python dependencies in scope and duplicating these will
again just cause confusion over having it at one location only.

Signed-off-by: aszlig <aszlig@nix.build>
Co-Authored-By: aszlig <aszlig@nix.build>
2021-05-09 02:26:51 +02:00
Robert Hensing 71087b2bc4
nixos/testing-python.nix: Expose driver
(cherry picked from commit a2c9220568648b4528154ebd8e657add243ed0b4)
2021-05-09 02:26:40 +02:00
aszlig c362a28fcf
nixos/testing: Switch from black to pyflakes
So far, we have used "black" for formatting the test code, which is
rather strict and opinionated and when used inline in Nix expressions it
creates all sorts of trouble.

One of the main annoyances is that when using strings coming from Nix
expressions (eg. store paths or option definitions from NixOS modules),
completely unrelated changes could cause tests to fail, since eg. black
wants lines to be broken.

Another downside of enforcing a certain kind of formatting is that it
makes the Nix expression code inconsistent because we're mixing two
spaces of indentation (common in nixpkgs) with four spaces of
indentation as defined in PEP-8. While this is perfectly fine for
standalone Python files, it really looks ugly and inconsistent IMO when
used within Nix strings.

What we actually want though is a linter that catches problems early on
before actually running the test, because this is *actually* helping in
development because running the actual VM test takes much longer.

This is the reason why I switched from black to pyflakes, because the
latter actually has useful checks, eg. usage of undefined variables,
invalid format arguments, duplicate arguments, shadowed loop vars and
more.

Signed-off-by: aszlig <aszlig@nix.build>
Closes: https://github.com/NixOS/nixpkgs/issues/72964
2021-05-09 02:26:37 +02:00
Robert T. McGibbon 78c97f07c8 python39Packages.blist: fix build 2021-05-08 14:54:15 -07:00
Luke Granger-Brown 8268e64d0e python3Packages.hg-evolve: 10.3.0 -> 10.3.1
Fix compatibility with Mercurial 5.8.
2021-05-08 14:49:29 -07:00
Maximilian Bosch c98bdda0ae
Merge pull request #122060 from Ma27/hydra-maintainer-fix
maintainers/check-hydra-by-maintainer: use `pkgs.hydra-check` from package set itself
2021-05-08 23:23:54 +02:00
lsix 713a95e5d5
Merge pull request #121921 from dotlambda/graphite-web-scandir
python3Packages.graphite-web: fix build
2021-05-08 22:05:32 +01:00
Sandro 620342dea4
Merge pull request #121003 from r-ryantm/auto-update/galene
galene: 0.3 -> 0.3.3
2021-05-08 22:57:48 +02:00
Sandro fefb074100
Merge pull request #122139 from vs49688/navidrome
navidrome: 0.40.0 -> 0.42.1
2021-05-08 22:55:39 +02:00
Sandro 327bdb6c1c
Merge pull request #122022 from ymeister/rss-bridge
rss-bridge: 2020-11-10 -> 2021-04-25
2021-05-08 22:54:32 +02:00
Robert T. McGibbon eacd24aed2 python3Packages.pykerberos: 1.2.1 -> 1.2.3.dev0 2021-05-08 13:53:09 -07:00
OPNA2608 b690ceff5d superTuxKart: Fix aarch64-linux build 2021-05-08 13:52:35 -07:00
Sandro 97de15956a
Merge pull request #122123 from aanderse/kodi.packages.netflix
kodi.packages.netflix: 1.15.0 -> 1.15.1
2021-05-08 22:50:01 +02:00
Sandro 3baa705848
Merge pull request #122056 from eduardosm/gnome-shell-extension-disable-unredirect
gnomeExtensions.disable-unredirect: unstable-2021-01-17 -> unstable-2021-04-13
2021-05-08 22:48:46 +02:00
Robert T. McGibbon 34305cc1a0 python3Packages.pomegranate: 0.11.2 -> 0.13.5 2021-05-08 13:48:08 -07:00
Fabian Affolter 13f0da71e6 python3Packages.myjwt: 1.4.0 -> 1.5.0 2021-05-08 13:43:35 -07:00
Robert T. McGibbon f6987986d3 python3Packages.pillow-simd: 7.0.0.post3 -> 8.1.2 2021-05-08 13:40:56 -07:00
Robert T. McGibbon 34e037b636 python3Packages.tld: fix on darwin 2021-05-08 13:32:12 -07:00
Evils 6b6537841c liquidctl: 1.5.1 -> 1.6.1; fix and polish a bit
add python.pkgs.i2c-tools
  required since 1.5.0

add man page output
add bash completion
add udev rules file
add the incl. tests

add myself as a maintainer

and clarify license
2021-05-08 13:23:36 -07:00
Evils 27ed1b4b15 python.pkgs.i2c-tools: init at i2c-tools.version 2021-05-08 13:23:36 -07:00
Evils c78b9b47cf i2c-tools: switch to fetchgit and separate man
and clarify license
2021-05-08 13:23:36 -07:00
Jan Solanti 773f051c87 pipewire: 0.3.26 -> 0.3.27 2021-05-08 13:20:05 -07:00
Robert T. McGibbon 9d469535df python3Packages.fenics: fix build 2021-05-08 13:15:39 -07:00
Martin Weinelt f701e8d085
Merge pull request #122028 from fabaff/bump-python-miio 2021-05-08 22:02:21 +02:00
Robert Hensing 4433ba90aa
Merge pull request #121927 from rissson/nixos-unbound-fix-top-level-include
nixos/unbound: allow list of strings in top-level settings option type
2021-05-08 22:00:57 +02:00
Martin Weinelt af9d0dde55
Merge pull request #121776 from fabaff/bump-roombapy 2021-05-08 21:49:00 +02:00
Sandro 1b844ebaf5
Merge pull request #122079 from JRavi2/vim-deus
vimPlugins.vim-deus: init at 2021-03-28
2021-05-08 21:35:21 +02:00
Mica 8179b81106
prism: init at 0.1.1 (#121869)
Co-authored-by: Maciej Krüger <mkg20001@gmail.com>
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
2021-05-08 21:34:35 +02:00
Sandro 540680f657
Merge pull request #121697 from jojosch/nzbhydra2-jre
nzbhydra2: use openjdk11
2021-05-08 21:31:09 +02:00
Martin Weinelt ed59fa37f9
Merge pull request #122007 from fabaff/bump-plexapi
python3Packages.plexapi: 4.5.1 -> 4.5.2
2021-05-08 21:29:17 +02:00
Eduardo Sánchez Muñoz c94643ac4d gnomeExtensions.disable-unredirect: unstable-2021-01-17 -> unstable-2021-04-13
Enables support for GNOME 40
2021-05-08 21:22:09 +02:00
Pavol Rusnak f240b1f9aa
Merge pull request #122226 from lourkeur/update/bitcoin-gold
bitcoin-gold: 1.15.2 -> 1.17.3
2021-05-08 21:20:11 +02:00
Sandro 36ba78f7f4
Merge pull request #121426 from schmittlauch/cawbirdMaster 2021-05-08 21:19:49 +02:00
Sandro 05760c0e57
Merge pull request #122174 from yorickvP/upd-victoriametrics
victoriametrics: 1.54.1 -> 1.59.0
2021-05-08 21:19:12 +02:00
Fabian Affolter 735e1b2e3e
Merge pull request #121710 from fabaff/bump-python-vlc
python3Packages.python-vlc: 3.0.11115 -> 3.0.12118
2021-05-08 21:17:39 +02:00
Fabian Affolter b2f905f34e
Merge pull request #121593 from fabaff/fix-databases
python3Packages.aiopg: init at 1.2.1
2021-05-08 21:17:06 +02:00
Pavol Rusnak 01e851a036
Merge pull request #122232 from mattmelling/python-binance-21.05
python3Packages.python-binance: added missing ujson dependency
2021-05-08 21:09:25 +02:00
Sandro 84a721ff5f
Merge pull request #121549 from hzeller/timg-142 2021-05-08 21:08:50 +02:00
Sandro 04734923e8
Merge pull request #122220 from sayanarijit/master
xplr: 0.5.12 -> 0.7.2
2021-05-08 21:08:31 +02:00
Pavol Rusnak 00727de1e0
Merge pull request #122229 from mattmelling/pika-21.05
python3Packages.pika: add gevent to checkInputs
2021-05-08 21:08:05 +02:00
Domen Kožar be91d80191
Merge pull request #119540 from chvp/nixos-rebuild-remote-flakes
nixos-rebuild: Allow remote building when using flakes
2021-05-08 21:07:47 +02:00
Sandro a74e97abc0
Merge pull request #121977 from r-ryantm/auto-update/doctl
doctl: 1.59.0 -> 1.60.0
2021-05-08 21:03:53 +02:00